decl_hdf5 MPI-I/O Collective or Independent, fix #419 #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorice91
changed the title
jmorice91
requested review from
jbigot,
benoitmartin88,
JAuriac and
Yushan-Wang
17 tasks
|
Previous review are in #494 |
Yushan-Wang
previously approved these changes
Nov 28, 2024
JAuriac
previously approved these changes
Dec 2, 2024
plugins/decl_hdf5/tests/compatibility_tests/PDI_C/mpi_independent_read_test.c
Outdated
Show resolved
Hide resolved
plugins/decl_hdf5/tests/compatibility_tests/PDI_C/mpi_independent_write_test.c
Outdated
Show resolved
Hide resolved
Yushan-Wang
approved these changes
Dec 4, 2024
benoitmartin88
approved these changes
Dec 11, 2024
| { | ||
| Raii_hid xfer_lst = make_raii_hid(H5Pcreate(H5P_DATASET_XFER), H5Pclose); | ||
| if (use_mpio) { | ||
| if (0 > H5Pset_dxpl_mpio(xfer_lst, m_mpio)) handle_hdf5_err(); |
There was a problem hiding this comment.
My personal opinion: I think that all if/else blocks should use curly braces, even if there is only 1 line.
Suggested change
| if (0 > H5Pset_dxpl_mpio(xfer_lst, m_mpio)) handle_hdf5_err(); | |
| if (0 > H5Pset_dxpl_mpio(xfer_lst, m_mpio)) { | |
| handle_hdf5_err(); | |
| } |
Comment on lines
220
to
222
| if (m_direction == READ) | ||
| do_read(ctx, h5_file, xfer_lst); | ||
| else |
There was a problem hiding this comment.
Suggested change
| if (m_direction == READ) | |
| do_read(ctx, h5_file, xfer_lst); | |
| else | |
| if (m_direction == READ) { | |
| do_read(ctx, h5_file, xfer_lst); | |
| } else { |
| @@ -328,7 +340,7 @@ hid_t Dataset_op::dataset_creation_plist(Context& ctx, const Datatype* dataset_t | |||
| return dset_plist; | |||
There was a problem hiding this comment.
Suggested change
| return dset_plist; | |
| return dset_plist; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibility to choose parallel MPIIO pointer (COLLECTIVE/INDEPENDENT) for hdf5 in parallel.
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format;Fix #issuekeyword to autoclose the issue when merged.